Restrict result file permissions and redact agent output#39
Merged
Conversation
- Write .thinktank/ files with mode 0o600 (owner read/write only) - Redact agent stdout/stderr from saved JSON results to prevent credential exposure from build output or Claude debug logs - Worktrees still available for full output inspection Closes #24 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Self-review: Redaction preserves all scoring-relevant fields (diff, filesChanged, linesAdded, etc.) while removing stdout/stderr. File permissions restrict access on Unix; Windows ignores mode but the redaction still protects. 40 tests pass, lint clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.thinktank/result files with mode 0o600 (owner-only access)Change type
Related issue
Closes #24
How to test
thinktank run "add a comment" -n 2.thinktank/latest.json— agent output should say "[redacted]"stat -c %a .thinktank/latest.jsonshould show600Breaking changes
Saved result files no longer contain agent stdout/stderr. Use worktrees to inspect full output.
🤖 Generated with Claude Code